Conversation
This comment has been minimized.
This comment has been minimized.
app initapp init
|
Will need to figure out why unit tests are failing. Works on my machine ™️. |
|
/snapit |
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Test the snapshot by installing your package globally: npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20251120104339Caution After installing, validate the version by running just |
Coverage report
Test suite run success3775 tests passing in 1455 suites. Report generated by 🧪jest coverage report action from c717875 |
250ba03 to
94b8275
Compare
|
Converted PR to Draft to avoid merging before required server-side changes. |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/environment.d.ts@@ -53,7 +53,7 @@ export declare function jsonOutputEnabled(environment?: NodeJS.ProcessEnv): bool
/**
* If true, the CLI should not use the Partners API.
*
- * @returns True if the SHOPIFY_CLI_NEVER_USE_PARTNERS_API environment variable is set.
+ * @returns True when SHOPIFY_CLI_NEVER_USE_PARTNERS_API is set or SHOPIFY_CLI_1P_DEV is not set.
*/
export declare function blockPartnersAccess(): boolean;
/**
|
94b8275 to
37f0070
Compare
|
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. |
|
Still relevant. |
|
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. |
|
Should we merge this now that we have app limits? |
37f0070 to
c717875
Compare
|
/snapit |
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Test the snapshot by installing your package globally: npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260223092423Caution After installing, validate the version by running |
gonzaloriestra
left a comment
There was a problem hiding this comment.
Tested again, all good! 👍
dmerand
left a comment
There was a problem hiding this comment.
This works as expected! I added a small note about error messages.
| // If an organization-id is provided, fetch the organization directly | ||
| const matchingOrg = await developerPlatformClient.orgFromId(flags['organization-id']) | ||
| if (!matchingOrg) { | ||
| throw new AbortError( |
There was a problem hiding this comment.
Nit: I did not get this helpful message when sending a non-integer as a parameter -- just got a bare GraphQL error. Perhaps we could use typing or otherwise be more defensive about input?

WHY are these changes introduced?
The
app initcommand has interactive prompts that are impossible to bypass. This prevents scripting and some agentic use.(Agentic use may still be difficult as the agent needs to obtain the organization ID, but this puts us a step closer.)
WHAT is this pull request doing?
organization-idflag to suppress organization selectionnameflag suppresses interactive linking and name promptsinitcommandSHOPIFY_FLAG_CLIENT_IDenvironment definition in our GitHub actions to the acceptance test job specifically (where it's needed), since it was breaking the newapp inittestsHow to test your changes?
The following commands should all be successful:
The following should fail:
Measuring impact
How do we know this change was effective? Please choose one:
Checklist